Re: [PATCH] kernel/cpu.c: fix many errors related to style.

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kernel/cpu.c: fix many errors related to style.
Date	2017-05-06 17:30 +0200
Message-ID	<tE9OF-1nG-7@gated-at.bofh.it> (permalink)
References	<tE9EZ-1kH-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2017-05-06 at 17:09 +0200, Matej Dujava wrote:
> This patch fixes the checkpatch.pl warning:
> ERROR: spaces required around that '=' (ctx:VxW)
> WARNING: Block comments use a trailing */ on a separate line
> CHECK: Please don't use multiple blank lines
> CHECK: Blank lines aren't necessary before a close brace '}'
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Blank lines aren't necessary after an open brace '{'
[]
> diff --git a/kernel/cpu.c b/kernel/cpu.c

Please don't modify core kernel files just to shut-up checkpatch
messages.  If you are doing rework, it makes some sense, otherwise
it doesn't add much value.

> -	/* Entry state on starting. Interrupts enabled from here on. Transient
> -	 * state for synchronsization */
> +	/*
> +	 * Entry state on starting. Interrupts enabled from here on. Transient
> +	 * state for synchronsization

Fixing typos would be nicer than merely reformatting comments.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kernel/cpu.c: fix many errors related to style. Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-06 17:20 +0200
  Re: [PATCH] kernel/cpu.c: fix many errors related to style. Joe Perches <joe@perches.com> - 2017-05-06 17:30 +0200

csiph-web