Re: [PATCH 1/1] rtc: gemini: add return value validation

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] rtc: gemini: add return value validation
Date	2017-05-05 01:00 +0200
Message-ID	<tDxT3-1mh-13@gated-at.bofh.it> (permalink)
References	<tzphn-ck-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 23/04/2017 at 20:48:07 +0800, Pan Bian wrote:
> From: Pan Bian <bianpan2016@163.com>
> 
> Function devm_ioremap() will return a NULL pointer if it fails to remap
> IO address, and its return value should be validated before it is used.
> However, in function gemini_rtc_probe(), its return value is not
> checked. This may result in bad memory access bugs on future access,
> e.g. calling the function gemini_rtc_read_time().
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
>  drivers/rtc/rtc-gemini.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] rtc: gemini: add return value validation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-05 01:00 +0200

csiph-web