Re: [PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL
Date	2017-05-04 14:50 +0200
Message-ID	<tDomK-3tZ-23@gated-at.bofh.it> (permalink)
References	<tzUlb-4gQ-7@gated-at.bofh.it> <tzUlb-4gQ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 24/04/2017 at 15:05:12 -0700, Moritz Fischer wrote:
> Fix commit 920f91e50c5b ("drivers/rtc/rtc-ds1374.c: add watchdog support")
> 
> The WDIOC_SETOPTIONS case in the watchdog ioctl would alwayss falls
> through to the -EINVAL case. This is wrong since thew watchdog does
> actually get stopped or started correctly.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
>  drivers/rtc/rtc-ds1374.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL Moritz Fischer <mdf@kernel.org> - 2017-04-25 00:10 +0200
  Re: [PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always  returning -EINVAL Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-04 14:50 +0200

csiph-web