Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636740

[PATCH 6/7] kernel-trace: Adjust two checks for null pointers in uprobe_buffer_init()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 5 May 2017 22:30:16 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 kernel/trace/trace_uprobe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 3e662d7ea6a4..e9c1865f7397 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -705,13 +705,13 @@ static int uprobe_buffer_init(void)
 	int cpu, err_cpu;
 
 	uprobe_cpu_buffer = alloc_percpu(struct uprobe_cpu_buffer);
-	if (uprobe_cpu_buffer == NULL)
+	if (!uprobe_cpu_buffer)
 		return -ENOMEM;
 
 	for_each_possible_cpu(cpu) {
 		struct page *p = alloc_pages_node(cpu_to_node(cpu),
 						  GFP_KERNEL, 0);
-		if (p == NULL) {
+		if (!p) {
 			err_cpu = cpu;
 			goto err;
 		}
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] kernel-trace: Fine-tuning for seven function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 6/7] kernel-trace: Adjust two checks for null pointers in  uprobe_buffer_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 4/7] kernel-trace: Improve a size determination in  create_hist_field() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 5/7] kernel-trace: Replace two seq_printf() calls by  seq_puts() in probes_seq_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  Re: [PATCH 0/7] kernel-trace: Fine-tuning for seven function  implementations Steven Rostedt <rostedt@goodmis.org> - 2017-05-05 23:10 +0200
    Re: kernel-trace: Fine-tuning for seven function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:30 +0200
  [PATCH 2/7] kernel-trace: Replace five seq_puts() calls by seq_putc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 6/7] kernel-trace: Adjust two checks for null pointers in  uprobe_buffer_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 1/7] kernel-trace: Combine two function calls into one in  hist_trigger_entry_print() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 3/7] kernel-trace: Adjust two checks for null pointers in  compatible_field() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 7/7] kernel-trace: Delete an error message for a failed memory  allocation in create_trace_uprobe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:20 +0200

csiph-web