Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636739

[PATCH 2/7] kernel-trace: Replace five seq_puts() calls by seq_putc()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 5 May 2017 19:45:12 +0200

Five single characters should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 kernel/trace/trace_events_hist.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index 94999934ffd5..df566e21344d 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -1013,7 +1013,7 @@ hist_trigger_entry_print(struct seq_file *m,
 	}
 
 	if (!multiline)
-		seq_puts(m, " ");
+		seq_putc(m, ' ');
 
 	seq_printf(m, "} hitcount: %10llu",
 		   tracing_map_read_sum(elt, HITCOUNT_IDX));
@@ -1030,7 +1030,7 @@ hist_trigger_entry_print(struct seq_file *m,
 		}
 	}
 
-	seq_puts(m, "\n");
+	seq_putc(m, '\n');
 }
 
 static int print_entries(struct seq_file *m,
@@ -1168,7 +1168,7 @@ static int event_hist_trigger_print(struct seq_file *m,
 		key_field = hist_data->fields[i];
 
 		if (i > hist_data->n_vals)
-			seq_puts(m, ",");
+			seq_putc(m, ',');
 
 		if (key_field->flags & HIST_FIELD_FL_STACKTRACE)
 			seq_puts(m, "stacktrace");
@@ -1182,7 +1182,7 @@ static int event_hist_trigger_print(struct seq_file *m,
 		if (i == HITCOUNT_IDX)
 			seq_puts(m, "hitcount");
 		else {
-			seq_puts(m, ",");
+			seq_putc(m, ',');
 			hist_field_print(m, hist_data->fields[i]);
 		}
 	}
@@ -1195,7 +1195,7 @@ static int event_hist_trigger_print(struct seq_file *m,
 		sort_key = &hist_data->sort_keys[i];
 
 		if (i > 0)
-			seq_puts(m, ",");
+			seq_putc(m, ',');
 
 		if (sort_key->field_idx == HITCOUNT_IDX)
 			seq_puts(m, "hitcount");
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] kernel-trace: Fine-tuning for seven function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 6/7] kernel-trace: Adjust two checks for null pointers in  uprobe_buffer_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 4/7] kernel-trace: Improve a size determination in  create_hist_field() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 5/7] kernel-trace: Replace two seq_printf() calls by  seq_puts() in probes_seq_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  Re: [PATCH 0/7] kernel-trace: Fine-tuning for seven function  implementations Steven Rostedt <rostedt@goodmis.org> - 2017-05-05 23:10 +0200
    Re: kernel-trace: Fine-tuning for seven function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:30 +0200
  [PATCH 2/7] kernel-trace: Replace five seq_puts() calls by seq_putc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 6/7] kernel-trace: Adjust two checks for null pointers in  uprobe_buffer_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 1/7] kernel-trace: Combine two function calls into one in  hist_trigger_entry_print() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 3/7] kernel-trace: Adjust two checks for null pointers in  compatible_field() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:10 +0200
  [PATCH 7/7] kernel-trace: Delete an error message for a failed memory  allocation in create_trace_uprobe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-05 23:20 +0200

csiph-web