Re: [PATCH v4 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D.

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D.
Date	2017-05-03 21:10 +0200
Message-ID	<tD7OW-13Q-3@gated-at.bofh.it> (permalink)
References	<tBmS5-5Fv-5@gated-at.bofh.it> <tBmS5-5Fv-11@gated-at.bofh.it> <tCCi6-4Jn-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Daniel Vetter <daniel@ffwll.ch> writes:

> On Fri, Apr 28, 2017 at 03:42:22PM -0700, Eric Anholt wrote:
>> The FBDEV initialization would throw an error in dmesg, when we just
>> want to silently not initialize fbdev on a V3D-only VC4 instance.
>> 
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>
> With the commit message updated that passing num_connector is the bug that
> throws the error (and not that we set up a no-op fbdev):
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Still kinda hoping for a follow-up to entirely get rid fo num_connector in
> the fbdev init funcs.

New commit message:

    drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D.
    
    There's no sense in having an fbdev if there's no display, since
    connectors don't get hotplugged to this hardware.  On Cygnus we were
    getting a dmesg error from passing in num_connectors (0), when that
    argument is supposed to be the maximum number of cloned connectors per
    CRTC (1).

Still no drm-misc acks on the other two patches, so I don't think I can
merge them.

Thread

[PATCH v4 1/3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-29 00:50 +0200
  [PATCH v4 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-29 00:50 +0200
    Re: [PATCH v4 2/3] drm/vc4: Don't try to initialize FBDEV if we're  only bound to V3D. Daniel Vetter <daniel@ffwll.ch> - 2017-05-02 11:30 +0200
      Re: [PATCH v4 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-05-03 21:10 +0200
  [PATCH v4 3/3] drm/vc4: Add specific compatible strings for Cygnus. Eric Anholt <eric@anholt.net> - 2017-04-29 00:50 +0200
  Re: [PATCH v4 1/3] drm/vc4: Turn the V3D clock on at runtime. Rob Herring <robh+dt@kernel.org> - 2017-05-02 01:10 +0200

csiph-web