Re: [PATCH net] net: hns: fix ethtool_get_strings overflow in hns driver

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] net: hns: fix ethtool_get_strings overflow in hns driver
Date	2017-04-28 22:20 +0200
Message-ID	<tBkwW-45D-19@gated-at.bofh.it> (permalink)
References	<tASAG-1Ma-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Timmy Li <lixiaoping3@huawei.com>
Date: Thu, 27 Apr 2017 22:18:16 +0800

> @@ -672,7 +672,7 @@ static void hns_gmac_get_strings(u32 stringset, u8 *data)
>  
>  static int hns_gmac_get_sset_count(int stringset)
>  {
> -	if (stringset == ETH_SS_STATS)
> +	if ((stringset == ETH_SS_STATS) || (stringset == ETH_SS_PRIV_FLAGS))

Excessive parenthesis, please fix this in your entire patch.

Thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] net: hns: fix ethtool_get_strings overflow in hns driver Timmy Li <lixiaoping3@huawei.com> - 2017-04-27 16:30 +0200
  Re: [PATCH net] net: hns: fix ethtool_get_strings overflow in hns  driver David Miller <davem@davemloft.net> - 2017-04-28 22:20 +0200

csiph-web