Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1633394
| From | Mike Christie <mchristi@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 1/2] tcmu: Add dynamic growing data area feature support |
| Date | 2017-04-30 07:50 +0200 |
| Message-ID | <tBPU5-7Ih-1@gated-at.bofh.it> (permalink) |
| References | <tAoCC-6Wg-15@gated-at.bofh.it> <tAoCC-6Wg-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/26/2017 01:25 AM, lixiubo@cmss.chinamobile.com wrote:
> for_each_sg(data_sg, sg, data_nents, i) {
> @@ -275,22 +371,26 @@ static void alloc_and_scatter_data_area(struct tcmu_dev *udev,
> from = kmap_atomic(sg_page(sg)) + sg->offset;
> while (sg_remaining > 0) {
> if (block_remaining == 0) {
> - block = find_first_zero_bit(udev->data_bitmap,
> - DATA_BLOCK_BITS);
> block_remaining = DATA_BLOCK_SIZE;
> - set_bit(block, udev->data_bitmap);
> + dbi = tcmu_get_empty_block(udev, &to);
> + if (dbi < 0)
I know it you fixed the missing kunmap_atomic here and missing unlock in
tcmu_queue_cmd_ring in the next patch, but I think normally people
prefer that one patch does not add a bug, then the next patch fixes it.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 1/2] tcmu: Add dynamic growing data area feature support lixiubo@cmss.chinamobile.com - 2017-04-26 08:30 +0200
Re: [PATCH v6 1/2] tcmu: Add dynamic growing data area feature support Mike Christie <mchristi@redhat.com> - 2017-04-30 07:50 +0200
Re: [PATCH v6 1/2] tcmu: Add dynamic growing data area featuresupport Xiubo Li <lixiubo@cmss.chinamobile.com> - 2017-04-30 12:30 +0200
Re: [PATCH v6 1/2] tcmu: Add dynamic growing data area featuresupport Mike Christie <mchristi@redhat.com> - 2017-05-01 20:40 +0200
csiph-web