Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1631540

[PATCH 2/3] ti-soc-thermal: Delete error messages for failed memory allocations in ti_bandgap_build()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 26 Apr 2017 17:03:07 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such statements here.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/thermal/ti-soc-thermal/ti-bandgap.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
index f19cb7612a65..109fb0a5f19f 100644
--- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
+++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
@@ -1217,7 +1217,5 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
-	if (!bgp) {
-		dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
+	if (!bgp)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	of_id = of_match_device(of_ti_bandgap_match, &pdev->dev);
 	if (of_id)
@@ -1229,7 +1227,5 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
-	if (!bgp->regval) {
-		dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
+	if (!bgp->regval)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	i = 0;
 	do {
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 17:40 +0200
  [PATCH 1/3] ti-soc-thermal: Use devm_kcalloc() in ti_bandgap_build() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 17:40 +0200
    Re: [PATCH 1/3] ti-soc-thermal: Use devm_kcalloc() in  ti_bandgap_build() Keerthy <j-keerthy@ti.com> - 2017-05-02 06:00 +0200
  [PATCH 2/3] ti-soc-thermal: Delete error messages for failed memory  allocations in ti_bandgap_build() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 17:50 +0200
    Re: [PATCH 2/3] ti-soc-thermal: Delete error messages for failed  memory allocations in ti_bandgap_build() Keerthy <j-keerthy@ti.com> - 2017-05-02 06:00 +0200
  [PATCH 3/3] ti-soc-thermal: Fix a typo in a comment line SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 17:50 +0200
    Re: [PATCH 3/3] ti-soc-thermal: Fix a typo in a comment line Keerthy <j-keerthy@ti.com> - 2017-05-02 06:00 +0200
  Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions Eduardo Valentin <edubezval@gmail.com> - 2017-04-27 18:30 +0200
    Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions Keerthy <j-keerthy@ti.com> - 2017-05-01 07:30 +0200
      Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions Keerthy <j-keerthy@ti.com> - 2017-05-02 07:00 +0200

csiph-web