Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1631118
| From | Charles Chiou <ch1102chiou@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] scsi: stex: make S6flag static |
| Date | 2017-04-26 04:50 +0200 |
| Message-ID | <tAlbH-4FT-3@gated-at.bofh.it> (permalink) |
| References | <tAcBr-7Ga-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Looks good to me.
Thanks for the improvement.
On 4/26/2017 1:36 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> This module specific flag can be made static as it does
> not need to be in global scope.
>
> Reviewed-by: Charles Chiou <charles.chiou@tw.promise.com>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/stex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index 0751561b59da..9b20643ab49d 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -363,7 +363,7 @@ struct st_card_info {
> u16 sts_count;
> };
>
> -int S6flag;
> +static int S6flag;
> static int stex_halt(struct notifier_block *nb, ulong event, void *buf);
> static struct notifier_block stex_notifier = {
> stex_halt, NULL, 0
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] scsi: stex: make S6flag static Colin King <colin.king@canonical.com> - 2017-04-25 19:40 +0200 Re: [PATCH] scsi: stex: make S6flag static Charles Chiou <ch1102chiou@gmail.com> - 2017-04-26 04:50 +0200 Re: [PATCH] scsi: stex: make S6flag static "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-04-27 00:40 +0200
csiph-web