Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1631106

Re: [PATCH v4 2/4] zram: implement deduplication in zram

From Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 2/4] zram: implement deduplication in zram
Date 2017-04-26 04:20 +0200
Message-ID <tAkIF-4uM-5@gated-at.bofh.it> (permalink)
References <tAjtf-3t4-3@gated-at.bofh.it> <tAjtg-3t4-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hello,

On (04/26/17 09:52), js1304@gmail.com wrote:
[..]
>  	ret = scnprintf(buf, PAGE_SIZE,
> -			"%8llu %8llu %8llu %8lu %8ld %8llu %8lu\n",
> +			"%8llu %8llu %8llu %8lu %8ld %8llu %8lu %8llu %8llu\n",
>  			orig_size << PAGE_SHIFT,
>  			(u64)atomic64_read(&zram->stats.compr_data_size),
>  			mem_used << PAGE_SHIFT,
>  			zram->limit_pages << PAGE_SHIFT,
>  			max_used << PAGE_SHIFT,
>  			(u64)atomic64_read(&zram->stats.same_pages),
> -			pool_stats.pages_compacted);
> +			pool_stats.pages_compacted,
> +			zram_dedup_dup_size(zram),
> +			zram_dedup_meta_size(zram));

hm... should't we subtract zram_dedup_dup_size(zram) from
->stats.compr_data_size? we don't use extra memory for dedupped
pages. or don't inc ->stats.compr_data_size for dedupped pages?

for instance, same_page_write() does not inc ->stats.compr_data_size,
while successful zram_dedup_find() does (in __zram_bvec_write()).

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/4] zram: implement deduplication in zram js1304@gmail.com - 2017-04-26 03:00 +0200
  [PATCH v4 2/4] zram: implement deduplication in zram js1304@gmail.com - 2017-04-26 03:00 +0200
    Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-26 04:20 +0200
      Re: [PATCH v4 2/4] zram: implement deduplication in zram Joonsoo Kim <js1304@gmail.com> - 2017-04-26 08:00 +0200
        Re: [PATCH v4 2/4] zram: implement deduplication in zram Minchan Kim <minchan@kernel.org> - 2017-04-26 08:30 +0200
          Re: [PATCH v4 2/4] zram: implement deduplication in zram Joonsoo Kim <js1304@gmail.com> - 2017-04-26 09:10 +0200
            Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-26 09:30 +0200
              Re: [PATCH v4 2/4] zram: implement deduplication in zram Minchan Kim <minchan@kernel.org> - 2017-04-26 09:50 +0200
          Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-26 09:20 +0200
    Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-26 04:40 +0200
      Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-26 08:10 +0200
      Re: [PATCH v4 2/4] zram: implement deduplication in zram Joonsoo Kim <js1304@gmail.com> - 2017-04-26 08:10 +0200
    Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-26 06:10 +0200
      Re: [PATCH v4 2/4] zram: implement deduplication in zram Joonsoo Kim <js1304@gmail.com> - 2017-04-26 08:10 +0200
        Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-26 08:30 +0200
          Re: [PATCH v4 2/4] zram: implement deduplication in zram Joonsoo Kim <js1304@gmail.com> - 2017-04-27 09:00 +0200
            Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-27 09:50 +0200
              Re: [PATCH v4 2/4] zram: implement deduplication in zram Joonsoo Kim <js1304@gmail.com> - 2017-05-02 07:40 +0200
    Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-26 06:30 +0200
      Re: [PATCH v4 2/4] zram: implement deduplication in zram Joonsoo Kim <js1304@gmail.com> - 2017-04-26 08:10 +0200
        Re: [PATCH v4 2/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-26 08:20 +0200
  Re: [PATCH v4 0/4] zram: implement deduplication in zram Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-27 10:00 +0200

csiph-web