Re: [PATCH 2/3] selinux: add checksum to policydb

From	Sebastien Buisson <sbuisson.ddn@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] selinux: add checksum to policydb
Date	2017-04-27 19:20 +0200
Message-ID	<tAVfb-3DH-5@gated-at.bofh.it> (permalink)
References	<tAx3c-46S-13@gated-at.bofh.it> <tAx3c-46S-11@gated-at.bofh.it> <tAzRn-5Yn-5@gated-at.bofh.it> <tANhE-6ta-9@gated-at.bofh.it> <tATn3-2pt-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-04-27 17:18 GMT+02:00 Stephen Smalley <sds@tycho.nsa.gov>:
> Ok, that should work as long as you just want to validate that all the
> clients loaded the same policy file, and aren't concerned about non-
> persistent policy boolean changes.

As far as I understand, non-persistent policy boolean changes can
affect the way the policy is enforced. So that is a problem if the
checksum does not reflect it. We want to protect against someone
tampering the policy locally on a Lustre client, even if it does not
survive a reboot.
I just checked, with the method of computing the checksum on a (data,
len) pair on entry to security_load_policy() the checksum does not
change after using setsebool. So it seems I would need to call
security_read_policy() to retrieve the binary representation of the
policy as currently enforced by the kernel. Unless you can see another
way?

> You needed to get (global) enforcing mode too, didn't you?  That's
> separate from the policy.

Exactly, I also need to rework the patch I proposed about this, in
light of the comments I received.

> Make sure you make the hash algorithm explicit in both what is returned
> by the hook to lustre and by what is exported via selinuxfs.  Can
> likely just encode the hash algorithm name in the string when you
> generate it.

Sure, I will add "sha256:" at the beginning of the string.

Thread

[PATCH 2/3] selinux: add checksum to policydb Sebastien Buisson <sbuisson.ddn@gmail.com> - 2017-04-26 17:30 +0200
  Re: [PATCH 2/3] selinux: add checksum to policydb Stephen Smalley <sds@tycho.nsa.gov> - 2017-04-26 20:30 +0200
    Re: [PATCH 2/3] selinux: add checksum to policydb Sebastien Buisson <sbuisson.ddn@gmail.com> - 2017-04-27 10:50 +0200
      Re: [PATCH 2/3] selinux: add checksum to policydb Stephen Smalley <sds@tycho.nsa.gov> - 2017-04-27 17:20 +0200
        Re: [PATCH 2/3] selinux: add checksum to policydb Sebastien Buisson <sbuisson.ddn@gmail.com> - 2017-04-27 19:20 +0200
          Re: [PATCH 2/3] selinux: add checksum to policydb Stephen Smalley <sds@tycho.nsa.gov> - 2017-04-27 20:50 +0200
            Re: [PATCH 2/3] selinux: add checksum to policydb Sebastien Buisson <sbuisson.ddn@gmail.com> - 2017-04-28 17:20 +0200
              Re: [PATCH 2/3] selinux: add checksum to policydb Stephen Smalley <sds@tycho.nsa.gov> - 2017-04-28 17:50 +0200
                Re: [PATCH 2/3] selinux: add checksum to policydb Sebastien Buisson <sbuisson.ddn@gmail.com> - 2017-04-28 18:10 +0200
                Re: [PATCH 2/3] selinux: add checksum to policydb Stephen Smalley <sds@tycho.nsa.gov> - 2017-04-28 18:40 +0200

csiph-web