Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker.

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker.
Date	2017-02-10 16:00 +0100
Message-ID	<t9kQ2-4Jf-15@gated-at.bofh.it> (permalink)
References	(1 earlier) <t9gjo-23D-17@gated-at.bofh.it> <t9gCK-2aq-21@gated-at.bofh.it> <t9hIt-2Oi-9@gated-at.bofh.it> <t9jqW-3TZ-13@gated-at.bofh.it> <t9jqW-3TZ-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 10, 2017 at 02:02:19PM +0100, Dmitry Vyukov wrote:
> On Fri, Feb 10, 2017 at 1:15 PM, Andrey Ryabinin
> <aryabinin@virtuozzo.com> wrote:
> >
> >
> > On 02/10/2017 02:18 PM, Thomas Gleixner wrote:
> >> On Fri, 10 Feb 2017, Dmitry Vyukov wrote:

> >>> Could we default this rodata check to n under KASAN? Or at least print
> >>> some explanatory warning message before doing marking rodata (it
> >>> should be printed right before "hang", so if you stare at it for a
> >>> minute during each boot you realize that it may be related)?

Regardless of any optimisation work, I think it would make sense to both
log something in the debug_check_wx() and to default it off if KASAN is
selected.

That could be generic, so we don't have to alter each and every arch
port...

The WX check is a one-time boot check, and missing it for a KASAN kernel
isn't the end of the world, though I'd still like to be able to use the
userspace page table dumps.

Thanks,
Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker. Dmitry Vyukov <dvyukov@google.com> - 2017-02-10 11:30 +0100
  Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker. Thomas Gleixner <tglx@linutronix.de> - 2017-02-10 12:40 +0100
    Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker. Dmitry Vyukov <dvyukov@google.com> - 2017-02-10 14:30 +0100
      Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker. Dmitry Vyukov <dvyukov@google.com> - 2017-02-10 15:20 +0100
      Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker. Mark Rutland <mark.rutland@arm.com> - 2017-02-10 15:40 +0100
        Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker. Mark Rutland <mark.rutland@arm.com> - 2017-02-10 15:50 +0100
      Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker. Mark Rutland <mark.rutland@arm.com> - 2017-02-10 16:00 +0100

csiph-web