Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577890

Re: Intel PT decoder switch case fallthrough cases reported by gcc 7

Show all headers | View raw

Em Thu, Feb 09, 2017 at 10:25:19AM -0800, Andi Kleen escreveu:
> On Thu, Feb 09, 2017 at 01:50:39PM -0300, Arnaldo Carvalho de Melo wrote:
> > Hi,
> > 
> > 	I've updated the container with Fedora Rawhide I use to build
> > tools/perf/ and samples/bcc/ and it now comes with gcc 7, where I get
> > things like:
> 
> FWIW, but it just shows that you should never ship software with -Werror
> enabled. New compiler releases add new warnings, and you just randomly
> break the build for users who use newer compilers.
> 
> It's ok to use in your own builds, but should never be default.
> 
> The kernel gets it right, but perf is wrong here.

But what about my question? Do you think the changes are ok? I actually
made all be fallthrough, i.e. considered that the existing code was ok.

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Intel PT decoder switch case fallthrough cases reported by gcc 7 Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-09 18:00 +0100
  Re: Intel PT decoder switch case fallthrough cases reported by gcc 7 Andi Kleen <andi@firstfloor.org> - 2017-02-09 19:50 +0100
    Re: Intel PT decoder switch case fallthrough cases reported by gcc 7 Andi Kleen <andi@firstfloor.org> - 2017-02-09 20:20 +0100
      Re: Intel PT decoder switch case fallthrough cases reported by gcc 7 Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-09 20:30 +0100
    Re: Intel PT decoder switch case fallthrough cases reported by gcc 7 Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-09 20:20 +0100

csiph-web