Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577768

Re: [PATCH -next] bus: da850-mstpri: remove redundant dev_err call in da8xx_mstpri_probe()

Show all headers | View raw

2017-02-09 16:30 GMT+01:00 Wei Yongjun <weiyj.lk@gmail.com>:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/bus/da8xx-mstpri.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
> index 9af9bcc..5595af1 100644
> --- a/drivers/bus/da8xx-mstpri.c
> +++ b/drivers/bus/da8xx-mstpri.c
> @@ -218,10 +218,8 @@ static int da8xx_mstpri_probe(struct platform_device *pdev)
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         mstpri = devm_ioremap_resource(dev, res);
> -       if (IS_ERR(mstpri)) {
> -               dev_err(dev, "unable to map MSTPRI registers\n");
> +       if (IS_ERR(mstpri))
>                 return PTR_ERR(mstpri);
> -       }
>
>         prio_list = da8xx_mstpri_get_board_prio();
>         if (!prio_list) {
>
>
>

Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] bus: da850-mstpri: remove redundant dev_err call in da8xx_mstpri_probe() Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-09 16:40 +0100
  Re: [PATCH -next] bus: da850-mstpri: remove redundant dev_err call in da8xx_mstpri_probe() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-09 17:50 +0100

csiph-web