Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1576429
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 06/16] net: stmmac: fix some code style problem |
| Date | 2017-02-08 11:50 +0100 |
| Message-ID | <t8xZ0-7EC-15@gated-at.bofh.it> (permalink) |
| References | <t8vXb-6oU-3@gated-at.bofh.it> <t8vXc-6oU-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 2017-02-08 at 09:31 +0100, Corentin Labbe wrote:
> Checkpatch complains about some code style problem on stmmac_mdio.c.
> This patch fix them.
[]
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
[]
> @@ -258,6 +258,7 @@ int stmmac_mdio_register(struct net_device *ndev)
> found = 0;
> for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
> struct phy_device *phydev = mdiobus_get_phy(new_bus, addr);
> +
> if (phydev) {
> int act = 0;
> char irq_num[4];
Maybe use
if (!phydev)
continue;
to reduce indentation
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 06/16] net: stmmac: fix some code style problem Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-08 09:40 +0100
Re: [PATCH v2 06/16] net: stmmac: fix some code style problem Joe Perches <joe@perches.com> - 2017-02-08 11:50 +0100
Re: [PATCH v2 06/16] net: stmmac: fix some code style problem Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-08 16:10 +0100
Re: [PATCH v2 06/16] net: stmmac: fix some code style problem Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-02-08 13:40 +0100
csiph-web