Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577390

Re: [PATCH 05/10] sched/core: Remove the tsk_cpus_allowed() wrapper

Show all headers | View raw

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, Feb 08, 2017 at 07:34:18PM +0100, Ingo Molnar wrote:
>
> > So the original intention of tsk_cpus_allowed() was to 'future-proof' the 
> > field - but it's pretty ineffectual at that, because half of the code uses 
> > ->cpus_allowed directly ...
> > 
> > Also, the wrapper makes the code longer than the original expression!
> 
> I still object to taking this out without replacement.

Yeah, that would have been my next suggestion.

> This leaves RT stranded.

Well, no, it leaves -rt with slightly more patching work than it already has...

Because note how the wrappery is _already_ incomplete to a significant degree:

  triton:~/tip> git grep -Ee '->cpus_allowed' | grep -vE 'tsk_|cpuset|core.c' | wc -l
  27
  triton:~/tip> git grep tsk_cpus_allowed | wc -l
  43

I.e. around 40% of the places that use ->cpus_allowed in the upstream kernel are 
not properly wrapped. That fact already 'wrecks' -rt.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 05/10] sched/core: Remove the tsk_cpus_allowed() wrapper Ingo Molnar <mingo@kernel.org> - 2017-02-08 19:40 +0100
  Re: [PATCH 05/10] sched/core: Remove the tsk_cpus_allowed() wrapper Peter Zijlstra <peterz@infradead.org> - 2017-02-09 10:00 +0100
    Re: [PATCH 05/10] sched/core: Remove the tsk_cpus_allowed() wrapper Ingo Molnar <mingo@kernel.org> - 2017-02-09 10:10 +0100
      Re: [PATCH 05/10] sched/core: Remove the tsk_cpus_allowed()  wrapper Thomas Gleixner <tglx@linutronix.de> - 2017-02-09 12:50 +0100
        Re: [PATCH 05/10] sched/core: Remove the tsk_cpus_allowed() wrapper Ingo Molnar <mingo@kernel.org> - 2017-02-09 21:30 +0100

csiph-web