Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577018

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

From Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver
Date 2017-02-08 21:20 +0100
Message-ID <t8GSC-4S1-15@gated-at.bofh.it> (permalink)
References (3 earlier) <t8CvD-240-1@gated-at.bofh.it> <t8DBo-2Hv-27@gated-at.bofh.it> <t8GfU-4p7-27@gated-at.bofh.it> <t8GfU-4p7-25@gated-at.bofh.it> <t8GSC-4S1-17@gated-at.bofh.it>
Organization Intel Finland Oy

Show all headers | View raw

On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote:
> On 02/08/2017 08:20 PM, Andy Shevchenko wrote:
> > On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote:
> > > On 02/08/2017 05:40 PM, Andy Shevchenko wrote:
> > > > On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote:
> > > > > On 02/08/2017 02:59 PM, Greg KH wrote:
> > > > > > 


>  Should I keep my inline {clr,set}_bit_in_byte() 
> functions an use BIT() in there, or delete them and use BIT()
> directly 
> in usb251xb_get_ofdata() ?

Does it make any sense?

Even just name of your function is longer than what it substitutes.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver Richard Leitner <richard.leitner@skidata.com> - 2017-02-08 10:00 +0100
  Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Richard Leitner <richard.leitner@skidata.com> - 2017-02-08 10:00 +0100
    Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Greg KH <gregkh@linuxfoundation.org> - 2017-02-08 14:20 +0100
  Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-08 14:30 +0100
    Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Greg KH <gregkh@linuxfoundation.org> - 2017-02-08 15:10 +0100
      Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Richard Leitner <richard.leitner@skidata.com> - 2017-02-08 16:40 +0100
        Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-08 17:50 +0100
          Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-08 20:40 +0100
            Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-08 21:20 +0100
              Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Richard Leitner <richard.leitner@skidata.com> - 2017-02-09 10:00 +0100
            Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Richard Leitner <dev@g0hl1n.net> - 2017-02-08 21:40 +0100
          Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller  Driver Richard Leitner <dev@g0hl1n.net> - 2017-02-08 22:00 +0100

csiph-web