Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575483

RE: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances

From 岩松信洋 / IWAMATSU，NOBUHIRO <nobuhiro.iwamatsu.kw@hitachi.com>
Newsgroups linux.kernel
Subject RE: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances
Date 2017-02-07 09:50 +0100
Message-ID <t89Dk-vJ-17@gated-at.bofh.it> (permalink)
References <t5vTI-2Xq-5@gated-at.bofh.it> <t5vTI-2Xq-11@gated-at.bofh.it> <t6xTr-1sC-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

Thanks for your review.

> -----Original Message-----
> From: Mark Salyzyn [mailto:salyzyn@android.com]
> Sent: Friday, February 03, 2017 7:18 AM
> To: 岩松信洋 / IWAMATSU，NOBUHIRO; Anton Vorontsov; Colin Cross; Kees Cook;
> Tony Luck
> Cc: linux-kernel@vger.kernel.org; Hiraku Toyooka; 阿口誠司 / AGUCHI，
> SEIJI
> Subject: Re: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances
> 
> On 01/30/2017 05:58 PM, Nobuhiro Iwamatsu wrote:
> > diff --git a/include/linux/pstore.h b/include/linux/pstore.h index
> > 0da29cae009b..7a5db4833b8a 100644
> > --- a/include/linux/pstore.h
> > +++ b/include/linux/pstore.h
> > @@ -55,6 +55,7 @@ struct pstore_info {
> >   	size_t		bufsize;
> >   	struct mutex	read_mutex;	/* serialize open/read/close */
> >   	int		flags;
> > +	unsigned int	num_pmsg;
> >   	int		(*open)(struct pstore_info *psi);
> >   	int		(*close)(struct pstore_info *psi);
> >   	ssize_t		(*read)(u64 *id, enum pstore_type_id *type,
> 
> Before patch there was an implication that num_pmsg was 1, after patch calloc
> leaves this at a value of 0. Please reconcile the functional difference
> that this causes.

Yes, I was pointed out here also by Kees.

I will fix this.

Best regards,
  Nobuhiro

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 2nd 0/4] pstore: ramoops: support multiple pmsg instances Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@hitachi.com> - 2017-01-31 03:00 +0100
  [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as generic function Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@hitachi.com> - 2017-01-31 03:00 +0100
    Re: [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as generic  function Mark Salyzyn <salyzyn@android.com> - 2017-02-02 23:20 +0100
      RE: [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as generic  function 岩松信洋 / IWAMATSU，NOBUHIRO          <nobuhiro.iwamatsu.kw@hitachi.com> - 2017-02-07 10:00 +0100
        Re: [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as generic  function Mark Salyzyn <salyzyn@android.com> - 2017-02-07 17:10 +0100
  [PATCH v4 2nd 4/4] selftests/pstore: add testcases for multiple pmsg instances Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@hitachi.com> - 2017-01-31 03:00 +0100
  [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@hitachi.com> - 2017-01-31 03:00 +0100
    Re: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances Kees Cook <keescook@chromium.org> - 2017-02-01 21:30 +0100
      RE: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances 岩松信洋 / IWAMATSU，NOBUHIRO          <nobuhiro.iwamatsu.kw@hitachi.com> - 2017-02-07 09:50 +0100
    Re: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances Mark Salyzyn <salyzyn@android.com> - 2017-02-02 23:20 +0100
      RE: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances 岩松信洋 / IWAMATSU，NOBUHIRO          <nobuhiro.iwamatsu.kw@hitachi.com> - 2017-02-07 09:50 +0100
  [PATCH v4 2nd 3/4] ramoops: support multiple pmsg instances Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@hitachi.com> - 2017-01-31 03:10 +0100

csiph-web