Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575442

[PATCH] spi: s3c64xx: fix inconsistency between binding and driver

Show all headers | View raw

Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS
line is not connected") introduced an inconsistency between the
binding where the disconnected CS line was marked as
'no-cs-readback' while the driver was erroneously checking for
'broken-cs'.

Check for 'no-cs-readback' in the driver as well.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
 drivers/spi/spi-s3c64xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index b8cd356d8d10..b392cca8fa4f 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -969,7 +969,7 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev)
 		sci->num_cs = temp;
 	}
 
-	sci->no_cs = of_property_read_bool(dev->of_node, "broken-cs");
+	sci->no_cs = of_property_read_bool(dev->of_node, "no-cs-readback");
 
 	return sci;
 }
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: s3c64xx: fix inconsistency between binding and driver Andi Shyti <andi.shyti@samsung.com> - 2017-02-07 09:10 +0100
  Re: [PATCH] spi: s3c64xx: fix inconsistency between binding and  driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-07 21:40 +0100
  Applied "spi: s3c64xx: fix inconsistency between binding and driver" to the spi tree Mark Brown <broonie@kernel.org> - 2017-02-13 20:00 +0100

csiph-web