Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox

From	Jani Nikula <jani.nikula@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox
Date	2017-02-06 13:10 +0100
Message-ID	<t7Qhj-4M3-5@gated-at.bofh.it> (permalink)
References	<t7MdH-1Vy-3@gated-at.bofh.it> <t7MdH-1Vy-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Mon, 06 Feb 2017, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Prompt user how to quickly jump to the item he/she is interested in.

:o

All these years. I... I didn't know. Thanks!

> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
>  scripts/kconfig/mconf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 315ce2c..23d5681 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -443,10 +443,10 @@ static void search_conf(void)
>  
>  		res = get_relations_str(sym_arr, &head);
>  		set_subtitle();
> -		dres = show_textbox_ext(_("Search Results"), (char *)
> -					str_get(&res), 0, 0, keys, &vscroll,
> -					&hscroll, &update_text, (void *)
> -					&data);
> +		dres = show_textbox_ext(
> +				_("Search Results (type the number to jump)"),
> +				(char *)str_get(&res), 0, 0, keys, &vscroll,
> +				&hscroll, &update_text, (void *)&data);

It would be even better and discoverable if this could be turned into a
dialog menu, so that you could navigate the search results using arrow
keys and hit enter to choose. But this is already an improvement.

>  		again = false;
>  		for (i = 0; i < JUMP_NB && keys[i]; i++)
>  			if (dres == keys[i]) {

-- 
Jani Nikula, Intel Open Source Technology Center

Thread

[PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du@intel.com - 2017-02-06 08:50 +0100
  Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox Jani Nikula <jani.nikula@linux.intel.com> - 2017-02-06 13:10 +0100
    Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search  result textbox "Du, Changbin" <changbin.du@intel.com> - 2017-02-07 04:20 +0100

csiph-web