Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

From	Roger Pau Monné <roger.pau@citrix.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC
Date	2017-02-02 16:50 +0100
Message-ID	<t6rO2-5RR-27@gated-at.bofh.it> (permalink)
References	<t3Ydu-2X9-77@gated-at.bofh.it> <t3YQa-3pI-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote:
> Make sure they don't use these devices since they are not emulated
> for unprivileged PVH guest.

This description seems weird for what it's actually done. AFAICT you are not
really preventing the guest from using the PIC or the IO APIC, because this is
fetched from the MADT table (or should be fetched from there in any case).

See below for the RTC...

[...]
> @@ -1892,6 +1900,9 @@ static void __init xen_hvm_guest_init(void)
>  
>  	init_hvm_pv_info();
>  
> +	if (xen_pvh_domain())
> +		x86_platform.legacy.rtc = 0;

Can't you fetch that from the FADT boot flags field? (See "5.2.9.3 IA-PC Boot
Architecture Flags" in ACPI 6.1 spec).

Roger.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC  and IOAPIC Roger Pau Monné <roger.pau@citrix.com> - 2017-02-02 16:50 +0100
  Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC  and IOAPIC Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-02 17:30 +0100
    Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC  and IOAPIC Roger Pau Monné <roger.pau@citrix.com> - 2017-02-02 18:10 +0100
      Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC  and IOAPIC Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-02 18:50 +0100

csiph-web