Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572423

Re: [PATCH] platform/x86: silead depends on I2C being built-in

Show all headers | View raw

Hi,

On 02-02-17 15:25, Arnd Bergmann wrote:
> The new driver cannot be a loadable module, so if I2C is loadable, we get this
> link error:
>
> drivers/platform/built-in.o: In function `silead_ts_dmi_init':
> silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type'
>
> This makes the Kconfig dependency stricter to require I2C=y.
>
> Fixes: 9eeda3897a85 ("platform/x86: add support for devices with Silead touchscreens")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thank you.

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards.

Hans


> ---
>  drivers/platform/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index dd4952ac8797..a7fe9b9f975d 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3
>
>  config SILEAD_DMI
>  	bool "Tablets with Silead touchscreens"
> -	depends on ACPI && DMI && I2C && INPUT
> +	depends on ACPI && DMI && I2C=y && INPUT
>  	---help---
>  	  Certain ACPI based tablets with Silead touchscreens do not have
>  	  enough data in ACPI tables for the touchscreen driver to handle
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: silead depends on I2C being built-in Arnd Bergmann <arnd@arndb.de> - 2017-02-02 15:30 +0100
  Re: [PATCH] platform/x86: silead depends on I2C being built-in Hans de Goede <hdegoede@redhat.com> - 2017-02-02 15:50 +0100
    Re: [PATCH] platform/x86: silead depends on I2C being built-in Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-02 16:10 +0100
      Re: [PATCH] platform/x86: silead depends on I2C being built-in Hans de Goede <hdegoede@redhat.com> - 2017-02-02 16:20 +0100
        Re: [PATCH] platform/x86: silead depends on I2C being built-in Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-02 16:30 +0100

csiph-web