Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static'

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static'
Date	2017-02-02 13:40 +0100
Message-ID	<t6oQ9-3WF-5@gated-at.bofh.it> (permalink)
References	<t6nU6-3lz-33@gated-at.bofh.it> <t6on8-3Ln-15@gated-at.bofh.it> <t6owO-3OM-11@gated-at.bofh.it> <t6oGt-3Tn-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 2, 2017 at 1:22 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Feb 02, 2017 at 01:11:36PM +0100, Arnd Bergmann wrote:
>> On Thu, Feb 2, 2017 at 1:04 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> > On Thu, Feb 2, 2017 at 12:34 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> >> I got a link error in allyesconfig:
>> >> Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.")
>> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> >
>> > Please disregard this patch version, it's broken.
>>
>> Too late, I see it's already applied, I'll send a follow-up to revert
>> the first hunk.
>
> Ah, I could have just dropped your patch (it's a testing branch that I
> can rebase), but I took your newer patch that fixed it up, so all is
> good.
>
> That's what I get for applying patches too quickly :)

I should really have been more careful about testing. I had the first
version in my
working tree while doing randconfig tests. None of the new randconfig builds
ran into the issue (the driver gets rarely enabled because of its dependencies),
and the original failure had already been marked as fixed in my build system
after an earlier patch only changed one of the prototypes.

    Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] staging: bcm2835: mark all symbols as 'static' Arnd Bergmann <arnd@arndb.de> - 2017-02-02 12:40 +0100
  Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static' Arnd Bergmann <arnd@arndb.de> - 2017-02-02 13:10 +0100
    Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static' Arnd Bergmann <arnd@arndb.de> - 2017-02-02 13:20 +0100
      Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static' Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-02 13:30 +0100
        Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static' Arnd Bergmann <arnd@arndb.de> - 2017-02-02 13:40 +0100

csiph-web