Re: [PATCH v2 4/8] arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/8] arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig
Date	2017-02-03 18:30 +0100
Message-ID	<t6PQl-4E2-1@gated-at.bofh.it> (permalink)
References	<t6L0l-1tH-3@gated-at.bofh.it> <t6L0m-1tH-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Gerd Hoffmann <kraxel@redhat.com> writes:

> ---
>  arch/arm/configs/bcm2835_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig
> index 4b89f4e..3767c24 100644
> --- a/arch/arm/configs/bcm2835_defconfig
> +++ b/arch/arm/configs/bcm2835_defconfig
> @@ -92,6 +92,7 @@ CONFIG_MMC=y
>  CONFIG_MMC_SDHCI=y
>  CONFIG_MMC_SDHCI_PLTFM=y
>  CONFIG_MMC_SDHCI_IPROC=y
> +CONFIG_MMC_BCM2835=y
>  CONFIG_NEW_LEDS=y
>  CONFIG_LEDS_CLASS=y
>  CONFIG_LEDS_GPIO=y

If you end up resubmitting this, could you extend the commit message of
the defconfig changes to explain why it's being done?  Something like:

"We need to enable this controller so that we can switch the SD card's
pinmux over to it by default, which will improve storage read/write
speed."

(even better if we have some sort of stats on how much better it is).

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/8] arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig Gerd Hoffmann <kraxel@redhat.com> - 2017-02-03 13:20 +0100
  Re: [PATCH v2 4/8] arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig Eric Anholt <eric@anholt.net> - 2017-02-03 18:30 +0100

csiph-web