Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1573281

Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs

Show all headers | View raw

On Fri, Feb 03, 2017 at 07:52:37PM +0300, Alexey Brodkin wrote:
> Current implemntation returns ENODEV if device tree node for
> phy is absent. But in reality there're many boards with the one
> and only PHY on board and MACs that may find a PHY by querying
> MDIO bus. One good example is STMMAC.

Humm, not so sure about that. That check for an OF node has always
been there, since day one for this driver.

What has changed recently is where it looks for these device tree
properties. It used to wrongly look in the MAC node. It was changed to
look in the PHY node. So this is probably the reason you are having
problems.

Having said that, your patch looks O.K.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: phy: dp83867: Fix for automatically detected PHYs Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-02-03 18:00 +0100
  Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs Andrew Lunn <andrew@lunn.ch> - 2017-02-03 18:20 +0100
    Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-02-03 18:40 +0100
      Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs Andrew Lunn <andrew@lunn.ch> - 2017-02-03 19:00 +0100
      Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs Florian Fainelli <f.fainelli@gmail.com> - 2017-02-03 19:40 +0100
        Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-02-06 20:20 +0100

csiph-web