Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1573119

[PATCH 1/6] genirq: allow assigning affinity to present but not online CPUs

Show all headers | View raw

This will allow us to spread MSI/MSI-X affinity over all present CPUs and
thus better deal with systems where cpus are take on and offline all the
time.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 kernel/irq/manage.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 6b669593e7eb..7a1424330f9c 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -354,22 +354,22 @@ static int setup_affinity(struct irq_desc *desc, struct cpumask *mask)
 
 	/*
 	 * Preserve the managed affinity setting and an userspace affinity
-	 * setup, but make sure that one of the targets is online.
+	 * setup, but make sure that one of the targets is present.
 	 */
 	if (irqd_affinity_is_managed(&desc->irq_data) ||
 	    irqd_has_set(&desc->irq_data, IRQD_AFFINITY_SET)) {
 		if (cpumask_intersects(desc->irq_common_data.affinity,
-				       cpu_online_mask))
+				       cpu_present_mask))
 			set = desc->irq_common_data.affinity;
 		else
 			irqd_clear(&desc->irq_data, IRQD_AFFINITY_SET);
 	}
 
-	cpumask_and(mask, cpu_online_mask, set);
+	cpumask_and(mask, cpu_present_mask, set);
 	if (node != NUMA_NO_NODE) {
 		const struct cpumask *nodemask = cpumask_of_node(node);
 
-		/* make sure at least one of the cpus in nodemask is online */
+		/* make sure at least one of the cpus in nodemask is present */
 		if (cpumask_intersects(mask, nodemask))
 			cpumask_and(mask, mask, nodemask);
 	}
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

spread MSI(-X) vectors to all possible CPUs Christoph Hellwig <hch@lst.de> - 2017-02-03 15:40 +0100
  [PATCH 1/6] genirq: allow assigning affinity to present but not online CPUs Christoph Hellwig <hch@lst.de> - 2017-02-03 15:40 +0100
  [PATCH 5/6] blk-mq: create hctx for each present CPU Christoph Hellwig <hch@lst.de> - 2017-02-03 15:40 +0100
  [PATCH 6/6] nvme: allocate queues for all possible CPUs Christoph Hellwig <hch@lst.de> - 2017-02-03 15:40 +0100
  [PATCH 4/6] blk-mq: include all present CPUs in the default queue mapping Christoph Hellwig <hch@lst.de> - 2017-02-03 15:40 +0100
  [PATCH 2/6] genirq/affinity: assign vectors to all present CPUs Christoph Hellwig <hch@lst.de> - 2017-02-03 15:40 +0100
  [PATCH 3/6] genirq/affinity: update CPU affinity for CPU hotplug events Christoph Hellwig <hch@lst.de> - 2017-02-03 15:40 +0100
    Re: [PATCH 3/6] genirq/affinity: update CPU affinity for CPU hotplug  events Thomas Gleixner <tglx@linutronix.de> - 2017-02-10 12:20 +0100

csiph-web