Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1569729

Re: [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188 SoC

From Alexander Kochetkov <al.kochet@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188 SoC
Date 2017-01-30 14:20 +0100
Message-ID <t5k2e-4rq-1@gated-at.bofh.it> (permalink)
References <t38eR-4bB-9@gated-at.bofh.it> <t38eS-4bB-25@gated-at.bofh.it> <t5i0s-3gH-59@gated-at.bofh.it> <t5ijM-3mW-13@gated-at.bofh.it> <t5iWu-3Pv-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> 30 янв. 2017 г., в 15:04, Daniel Lezcano <daniel.lezcano@linaro.org> написал(а):
> 
> There is no case when the rockchip timer is used for the clockevent.
The is already timer entry for rk3228 in the DT. And it act as clockevent. I guess it work as backup,
but I cannot test it also. In order to not break DT compatibility I had to provide one timer to be
initialized as clockevent. And implemented implicit rule the driver (first DT timer - clockevent,
second DT timer - clocksource) already exists for other timers.

> If I'm not wrong, you can check /proc/interrupts and see there is no interrupt
> on the rockchip timer.

Yes, you right here. I’ve temporary disable smp_twd to test rockchip timer interrupts.
There is no interrupt on the rockchip timer during normal work.

> - when the CPU enters a deep idle state. But such state does not exist on rk3188
ARM chip/revision specific?

> - when the system goes to suspend. But the timers are stopped in any case and
>   CPU0 is always on.
There is timer for rk3228 in the DT. I guess there are situations where it can be used.
May be the situations are also acceptable for rk3188? May be something like suspend to RAM or
suspend to HDD? I am not expert in that questions. I can do some tests if you give hint/link.

So, as I understood you suggest to leave only one timer what can be used as clocksource
only. I can implement that, but there should be DT rule what allow to setup timer
as clocksource only. I cannot do more without timer framework support.
Looks, like I have to wait your patch to implement that.

Alexander.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188 SoC Alexander Kochetkov <al.kochet@gmail.com> - 2017-01-24 13:20 +0100
  Re: [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188  SoC Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-01-30 12:10 +0100
    Re: [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188 SoC Alexander Kochetkov <al.kochet@gmail.com> - 2017-01-30 12:30 +0100
      Re: [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188  SoC Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-01-30 13:10 +0100
        Re: [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188 SoC Alexander Kochetkov <al.kochet@gmail.com> - 2017-01-30 14:20 +0100
          Re: [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188  SoC Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-01-30 14:40 +0100

csiph-web