Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1568520
| From | Josh Poimboeuf <jpoimboe@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 01/15] stacktrace/x86: add function for detecting reliable stack traces |
| Date | 2017-01-27 18:20 +0100 |
| Message-ID | <t4ilP-6Xe-11@gated-at.bofh.it> (permalink) |
| References | <t1n8l-3mv-7@gated-at.bofh.it> <t1n8m-3mv-21@gated-at.bofh.it> <t4axY-1Vz-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jan 27, 2017 at 09:47:08AM +0100, Miroslav Benes wrote:
>
> > diff --git a/include/linux/stacktrace.h b/include/linux/stacktrace.h
> > index 0a34489..8e8b67b 100644
> > --- a/include/linux/stacktrace.h
> > +++ b/include/linux/stacktrace.h
> > @@ -18,6 +18,8 @@ extern void save_stack_trace_regs(struct pt_regs *regs,
> > struct stack_trace *trace);
> > extern void save_stack_trace_tsk(struct task_struct *tsk,
> > struct stack_trace *trace);
> > +extern int save_stack_trace_tsk_reliable(struct task_struct *tsk,
> > + struct stack_trace *trace);
> >
> > extern void print_stack_trace(struct stack_trace *trace, int spaces);
> > extern int snprint_stack_trace(char *buf, size_t size,
> > @@ -29,12 +31,12 @@ extern void save_stack_trace_user(struct stack_trace *trace);
> > # define save_stack_trace_user(trace) do { } while (0)
> > #endif
> >
> > -#else
> > +#else /* !CONFIG_STACKTRACE */
> > # define save_stack_trace(trace) do { } while (0)
> > # define save_stack_trace_tsk(tsk, trace) do { } while (0)
> > # define save_stack_trace_user(trace) do { } while (0)
> > # define print_stack_trace(trace, spaces) do { } while (0)
> > # define snprint_stack_trace(buf, size, trace, spaces) do { } while (0)
>
> Is there a reason you did not define empty save_stack_trace_tsk_reliable()
> here? Right, it should not be needed now as livepatching is the only user,
> but still.
Agreed, thanks. I'll make the stub return an error, since an empty
stack trace isn't very reliable.
--
Josh
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v4 01/15] stacktrace/x86: add function for detecting reliable stack traces Josh Poimboeuf <jpoimboe@redhat.com> - 2017-01-19 16:50 +0100
Re: [PATCH v4 01/15] stacktrace/x86: add function for detecting reliable stack traces Petr Mladek <pmladek@suse.com> - 2017-01-26 15:00 +0100
Re: [PATCH v4 01/15] stacktrace/x86: add function for detecting reliable stack traces Josh Poimboeuf <jpoimboe@redhat.com> - 2017-01-26 19:00 +0100
Re: [PATCH v4 01/15] stacktrace/x86: add function for detecting reliable stack traces Miroslav Benes <mbenes@suse.cz> - 2017-01-27 10:00 +0100
Re: [PATCH v4 01/15] stacktrace/x86: add function for detecting reliable stack traces Josh Poimboeuf <jpoimboe@redhat.com> - 2017-01-27 18:20 +0100
csiph-web