Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1568922
| From | Peter Senna Tschudin <peter.senna@collabora.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge |
| Date | 2017-01-28 15:20 +0100 |
| Message-ID | <t4C1b-2wu-11@gated-at.bofh.it> (permalink) |
| References | <sUUVr-51r-5@gated-at.bofh.it> <sUUVr-51r-3@gated-at.bofh.it> <sWaYa-8ch-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote:
Hi Archit,
Thank you for the comments!
[...]
> > + total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH;
> > + if (total_size > EDID_LENGTH) {
> > + kfree(block);
> > + block = kmalloc(total_size, GFP_KERNEL);
> > + if (!block)
> > + return NULL;
> > +
> > + /* Yes, read the entire buffer, and do not skip the first
> > + * EDID_LENGTH bytes.
> > + */
>
> Is this the reason why you aren't using drm_do_get_edid()?
Yes, for some hw specific reason, it is necessary to read the entire
EDID buffer starting from 0, not block by block.
[...]
I fixed all your other suggestions. Thank you!
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge Peter Senna Tschudin <peter.senna@collabora.com> - 2017-01-28 15:20 +0100 Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge Jani Nikula <jani.nikula@linux.intel.com> - 2017-01-30 18:10 +0100
csiph-web