Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566641

[PATCH -next] eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.

Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/misc/eeprom/idt_89hpesx.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 25d47d0..f5f2c5a 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
 	pdev->ee_file->size = pdev->eesize;
 	ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
 	if (ret != 0) {
-		kfree(pdev->ee_file);
 		dev_err(dev, "Failed to create EEPROM sysfs-node");
 		return ret;
 	}
@@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
 
 	/* Remove EEPROM sysfs file */
 	sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
-
-	/* Free memory allocated for bin_attribute structure */
-	kfree(pdev->ee_file);
 }
 
 /*

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc Wei Yongjun <weiyj.lk@gmail.com> - 2017-01-25 15:20 +0100
  Re: [PATCH -next] eeprom: idt_89hpesx: Drop kfree for memory  allocated with devm_kzalloc Serge Semin <fancer.lancer@gmail.com> - 2017-01-26 13:50 +0100

csiph-web