Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1567491

Re: [PATCH v2] openrisc: migrate exception table users off module.h and onto extable.h

Show all headers | View raw

[Re: [PATCH v2] openrisc: migrate exception table users off module.h and onto extable.h] On 26/01/2017 (Thu 14:53) Stafford Horne wrote:

> On Wed, Jan 25, 2017 at 04:40:46PM -0500, Paul Gortmaker wrote:
> > These files were only including module.h for exception table related
> > functions.  We've now separated that content out into its own file
> > "extable.h" so now move over to that and avoid all the extra header
> > content in module.h that we don't really need to compile these files.
> > 
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Cc: Jonas Bonn <jonas@southpole.se>
> > Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> > Cc: Stafford Horne <shorne@gmail.com>
> > Cc: openrisc@lists.librecores.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > ---
> > 
> > [v2: add traps.c to conversion, as without a toolchain, I'm at the
> >  mercy of the things found by kbuild; fixing them iteratively... ]
> > 
> >  arch/openrisc/kernel/traps.c | 2 +-
> >  arch/openrisc/mm/fault.c     | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/openrisc/kernel/traps.c b/arch/openrisc/kernel/traps.c
> > index a4574cb4b0fb..73abb3ff4fa3 100644
> > --- a/arch/openrisc/kernel/traps.c
> > +++ b/arch/openrisc/kernel/traps.c
> > @@ -23,7 +23,7 @@
> >  #include <linux/init.h>
> >  #include <linux/sched.h>
> >  #include <linux/kernel.h>
> > -#include <linux/module.h>
> > +#include <linux/exception.h>
> 
> Is this correct or did you want extable.h?

Gah, of course.  Thanks for spotting that.  It will be good to have a
working cross compiler for or32 someday to spot thinko items like this.

Thanks,
Paul.
--

> 
> >  #include <linux/kmod.h>
> >  #include <linux/string.h>
> >  #include <linux/errno.h>
> > diff --git a/arch/openrisc/mm/fault.c b/arch/openrisc/mm/fault.c
> > index b1a7435e786a..53592a639744 100644
> > --- a/arch/openrisc/mm/fault.c
> > +++ b/arch/openrisc/mm/fault.c
> > @@ -17,7 +17,7 @@
> >  
> >  #include <linux/mm.h>
> >  #include <linux/interrupt.h>
> > -#include <linux/module.h>
> > +#include <linux/extable.h>
> >  #include <linux/sched.h>
> >  
> >  #include <linux/uaccess.h>
> > -- 
> > 2.11.0
> > 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/20] Finalize separation of extable.h from module.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 14/20] metag: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 13/20] arc: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
    Re: [PATCH 13/20] arc: migrate exception table users off module.h and  onto extable.h Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-01-23 22:20 +0100
  [PATCH 06/20] mn10300: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 19/20] core: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 12/20] nios2: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
    Re: [PATCH 12/20] nios2: migrate exception table users off module.h  and onto extable.h Tobias Klauser <tklauser@distanz.ch> - 2017-01-25 11:00 +0100
  [PATCH 05/20] alpha: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 18/20] hexagon: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 16/20] unicore32: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 02/20] ia64: ensure exception table search users include extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 10/20] openrisc: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
    [PATCH v2] openrisc: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-25 22:50 +0100
      Re: [PATCH v2] openrisc: migrate exception table users off module.h  and onto extable.h Stafford Horne <shorne@gmail.com> - 2017-01-26 07:00 +0100
        Re: [PATCH v2] openrisc: migrate exception table users off module.h  and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-26 16:00 +0100
    [PATCH v2] openrisc: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-25 23:50 +0100
  [PATCH 09/20] frv: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 04/20] arm: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 08/20] sh: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 20/20] module.h: remove extable.h include now users have migrated Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
    Re: [PATCH 20/20] module.h: remove extable.h include now users have  migrated kbuild test robot <lkp@intel.com> - 2017-01-23 00:00 +0100
      Re: [PATCH 20/20] module.h: remove extable.h include now users have  migrated Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-23 05:20 +0100
  [PATCH 03/20] m32r: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 15/20] score: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 17/20] microblaze: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 01/20] ia64: move ia64_done_with_exception out of asm/uaccess.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 07/20] xtensa: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100

csiph-web