Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1567248

Re: [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty pages on the LRU

Show all headers | View raw

On Mon, Jan 23, 2017 at 01:16:38PM -0500, Johannes Weiner wrote:
> Memory pressure can put dirty pages at the end of the LRU without
> anybody running into dirty limits. Don't start writing individual
> pages from kswapd while the flushers might be asleep.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

I don't understand the motivation for checking the wb_reason name. Maybe
it was easier to eyeball while reading ftraces. The comment about the
flusher not doing its job could also be as simple as the writes took
place and clean pages were reclaimed before dirty_expire was reached.
Not impossible if there was a light writer combined with a heavy reader
or a large number of anonymous faults.

Anyway;

Acked-by: Mel Gorman <mgorman@suse.de>

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] mm: vmscan: fix kswapd writeback regression Johannes Weiner <hannes@cmpxchg.org> - 2017-01-23 19:20 +0100
  [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty pages on the LRU Johannes Weiner <hannes@cmpxchg.org> - 2017-01-23 19:20 +0100
    Re: [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty  pages on the LRU Minchan Kim <minchan@kernel.org> - 2017-01-26 02:40 +0100
    Re: [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty  pages on the LRU Mel Gorman <mgorman@suse.de> - 2017-01-26 11:00 +0100
      Re: [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty  pages on the LRU Johannes Weiner <hannes@cmpxchg.org> - 2017-01-26 18:50 +0100
        Re: [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty  pages on the LRU Mel Gorman <mgorman@suse.de> - 2017-01-26 19:50 +0100
    Re: [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty  pages on the LRU Michal Hocko <mhocko@kernel.org> - 2017-01-26 14:20 +0100
  Re: [PATCH 0/5] mm: vmscan: fix kswapd writeback regression "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-26 06:50 +0100

csiph-web