Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564846

Re: [PATCH 4/8] clk: renesas: cpg-mssr: Add support for reset control

Show all headers | View raw

Hi Niklas,

On Fri, Jan 20, 2017 at 11:03 PM, Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> Nice patch! It took me a while to understand why you didn't need to read
> the register before writing to it in cpg_mssr_deassert() :-)

Yeah, deassertion and assertion are asymmetrical.

Note that on older (not yet supported) SH/R-Mobile parts, there are no
reset clear registers, and deassertion is symmetrical.

> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/8] clk: renesas: cpg-mssr: Add support for reset control Geert Uytterhoeven <geert+renesas@glider.be> - 2017-01-20 15:20 +0100
  Re: [PATCH 4/8] clk: renesas: cpg-mssr: Add support for reset  control Philipp Zabel <p.zabel@pengutronix.de> - 2017-01-20 17:30 +0100
    Re: [PATCH 4/8] clk: renesas: cpg-mssr: Add support for reset control Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-20 19:10 +0100
  Re: [PATCH 4/8] clk: renesas: cpg-mssr: Add support for reset control Niklas Söderlund          <niklas.soderlund@ragnatech.se> - 2017-01-20 23:10 +0100
    Re: [PATCH 4/8] clk: renesas: cpg-mssr: Add support for reset control Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-23 11:20 +0100
  Re: [PATCH 4/8] clk: renesas: cpg-mssr: Add support for reset control Stephen Boyd <sboyd@codeaurora.org> - 2017-01-21 01:40 +0100

csiph-web