Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1564658

Re: [PATCH 20/20] module.h: remove extable.h include now users have migrated

From Paul Gortmaker <paul.gortmaker@windriver.com>
Newsgroups linux.kernel
Subject Re: [PATCH 20/20] module.h: remove extable.h include now users have migrated
Date 2017-01-23 05:20 +0100
Message-ID <t2EgO-1Ep-7@gated-at.bofh.it> (permalink)
References <t2tlp-33i-55@gated-at.bofh.it> <t2zh8-6JM-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Re: [PATCH 20/20] module.h: remove extable.h include now users have migrated] On 23/01/2017 (Mon 06:52) kbuild test robot wrote:

> Hi Paul,
> 
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.10-rc5 next-20170120]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Paul-Gortmaker/ia64-move-ia64_done_with_exception-out-of-asm-uaccess-h/20170123-004155
> config: cris-etraxfs_defconfig (attached as .config)

Thanks (once again) for the build coverage.  I'd actually built cris
(allmodconfig) but strangely enough it didn't show this particular
defconfig issue.  I'll fix it to ensure this file includes extable.h 

Paul.
--

> compiler: cris-linux-gcc (GCC) 6.2.0
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=cris 
> 
> All error/warnings (new ones prefixed by >>):
> 
>    arch/cris/arch-v32/kernel/traps.c: In function 'fixup_BUG':
> >> arch/cris/arch-v32/kernel/traps.c:159:11: error: implicit declaration of function 'search_exception_tables' [-Werror=implicit-function-declaration]
>       fixup = search_exception_tables(instruction_pointer(regs) - 2);
>               ^~~~~~~~~~~~~~~~~~~~~~~
> >> arch/cris/arch-v32/kernel/traps.c:159:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>       fixup = search_exception_tables(instruction_pointer(regs) - 2);
>             ^
>    cc1: some warnings being treated as errors
> 
> vim +/search_exception_tables +159 arch/cris/arch-v32/kernel/traps.c
> 
> 51533b61 Mikael Starvik 2005-07-27  143  
> 9ce1ea75 Jesper Nilsson 2007-12-03  144  void fixup_BUG(struct pt_regs *regs)
> 51533b61 Mikael Starvik 2005-07-27  145  {
> 9ce1ea75 Jesper Nilsson 2007-12-03  146  	BUG_regs = *regs;
> 9ce1ea75 Jesper Nilsson 2007-12-03  147  
> 9ce1ea75 Jesper Nilsson 2007-12-03  148  #ifdef CONFIG_DEBUG_BUGVERBOSE
> 9ce1ea75 Jesper Nilsson 2007-12-03  149  	/*
> 9ce1ea75 Jesper Nilsson 2007-12-03  150  	 * Fixup the BUG arguments through exception handlers.
> 9ce1ea75 Jesper Nilsson 2007-12-03  151  	 */
> 9ce1ea75 Jesper Nilsson 2007-12-03  152  	{
> 9ce1ea75 Jesper Nilsson 2007-12-03  153  		const struct exception_table_entry *fixup;
> 9ce1ea75 Jesper Nilsson 2007-12-03  154  
> 9ce1ea75 Jesper Nilsson 2007-12-03  155  		/*
> 9ce1ea75 Jesper Nilsson 2007-12-03  156  		 * ERP points at the "break 14" + 2, compensate for the 2
> 9ce1ea75 Jesper Nilsson 2007-12-03  157  		 * bytes.
> 9ce1ea75 Jesper Nilsson 2007-12-03  158  		 */
> 9ce1ea75 Jesper Nilsson 2007-12-03 @159  		fixup = search_exception_tables(instruction_pointer(regs) - 2);
> 9ce1ea75 Jesper Nilsson 2007-12-03  160  		if (fixup) {
> 9ce1ea75 Jesper Nilsson 2007-12-03  161  			/* Adjust the instruction pointer in the stackframe. */
> 9ce1ea75 Jesper Nilsson 2007-12-03  162  			instruction_pointer(regs) = fixup->fixup;
> 9ce1ea75 Jesper Nilsson 2007-12-03  163  			arch_fixup(regs);
> 51533b61 Mikael Starvik 2005-07-27  164  		}
> 9ce1ea75 Jesper Nilsson 2007-12-03  165  	}
> 9ce1ea75 Jesper Nilsson 2007-12-03  166  #else
> 9ce1ea75 Jesper Nilsson 2007-12-03  167  	/* Dont try to lookup the filename + line, just dump regs.  */
> 
> :::::: The code at line 159 was first introduced by commit
> :::::: 9ce1ea751f7256b2248321c2427612a295f15137 CRIS v32: Update and improve kernel/traps.c
> 
> :::::: TO: Jesper Nilsson <jesper.nilsson@axis.com>
> :::::: CC: Jesper Nilsson <jesper.nilsson@axis.com>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 00/20] Finalize separation of extable.h from module.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 14/20] metag: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 13/20] arc: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
    Re: [PATCH 13/20] arc: migrate exception table users off module.h and  onto extable.h Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-01-23 22:20 +0100
  [PATCH 06/20] mn10300: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 19/20] core: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 12/20] nios2: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
    Re: [PATCH 12/20] nios2: migrate exception table users off module.h  and onto extable.h Tobias Klauser <tklauser@distanz.ch> - 2017-01-25 11:00 +0100
  [PATCH 05/20] alpha: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 18/20] hexagon: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 16/20] unicore32: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 02/20] ia64: ensure exception table search users include extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 10/20] openrisc: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
    [PATCH v2] openrisc: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-25 22:50 +0100
      Re: [PATCH v2] openrisc: migrate exception table users off module.h  and onto extable.h Stafford Horne <shorne@gmail.com> - 2017-01-26 07:00 +0100
        Re: [PATCH v2] openrisc: migrate exception table users off module.h  and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-26 16:00 +0100
    [PATCH v2] openrisc: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-25 23:50 +0100
  [PATCH 09/20] frv: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 04/20] arm: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 08/20] sh: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 20/20] module.h: remove extable.h include now users have migrated Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
    Re: [PATCH 20/20] module.h: remove extable.h include now users have  migrated kbuild test robot <lkp@intel.com> - 2017-01-23 00:00 +0100
      Re: [PATCH 20/20] module.h: remove extable.h include now users have  migrated Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-23 05:20 +0100
  [PATCH 03/20] m32r: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 15/20] score: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 17/20] microblaze: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 01/20] ia64: move ia64_done_with_exception out of asm/uaccess.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100
  [PATCH 07/20] xtensa: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-22 17:40 +0100

csiph-web