Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562193

Re: [PATCH 2/2] mmc: dt-bindings: update Mediatek MMC bindings

Show all headers | View raw

On Thu, Jan 12, 2017 at 06:04:50PM +0800, Yong Mao wrote:
> From: yong mao <yong.mao@mediatek.com>
> 
> Add description for hs200-cmd-int-delay
> Add description for hs400-cmd-int-delay
> Add description for cmd-resp-sel
> 
> Signed-off-by: Yong Mao <yong.mao@mediatek.com>
> ---
>  Documentation/devicetree/bindings/mmc/mtk-sd.txt |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> index 0120c7f..2dbb3b0 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> @@ -21,6 +21,9 @@ Optional properties:
>  - assigned-clocks: PLL of the source clock
>  - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock
>  - hs400-ds-delay: HS400 DS delay setting
> +- hs200-cmd-int-delay: HS200 command internal delay setting
> +- hs400-cmd-int-delay: HS400 command internal delay setting

What are the units and range of values? These need vendor prefix as 
well.

> +- cmd-resp-sel: command response sample selection

Looks like a boolean. State that and make the default the more common 
case.

>  
>  Examples:
>  mmc0: mmc@11230000 {
> @@ -38,4 +41,7 @@ mmc0: mmc@11230000 {
>  	assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>;
>  	assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>;
>  	hs400-ds-delay = <0x14015>;
> +	hs200-cmd-int-delay = <26>;
> +	hs400-cmd-int-delay = <14>;
> +	cmd-resp-sel = <0>; /* 0: rising, 1: falling */
>  };
> -- 
> 1.7.9.5
> 

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] mmc: dt-bindings: update Mediatek MMC bindings Rob Herring <robh@kernel.org> - 2017-01-18 22:40 +0100

csiph-web