Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561948

Re: [PATCH 07/11] perf, tools: Collapse identically named events in perf stat

Show all headers | View raw

> > % perf stat  -a  -e unc_c_llc_lookup.any sleep 1
> > 
> >  Performance counter stats for 'system wide':
> > 
> >          2,685,120 Bytes unc_c_llc_lookup.any
> > 
> >        1.002648032 seconds time elapsed
> 
> 
> if one of them is not supported, we get wrong output:


I would argue the output is not incorrect, after all it is not supported
if something is missing. 

Imagine this is run with an interval:

If we changed the number of output lines based on some dynamic scheduling
condition this could confuse post processing scripts or users. Some output
records would be completely different than others. So marking everything
merged <not supported> in these cases is better and more consistent.

It is also difficult to change and should be a rare condition.

-Andi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 07/11] perf, tools: Collapse identically named events in  perf stat Jiri Olsa <jolsa@redhat.com> - 2017-01-18 13:50 +0100
  Re: [PATCH 07/11] perf, tools: Collapse identically named events in  perf stat Andi Kleen <ak@linux.intel.com> - 2017-01-18 17:40 +0100
    Re: [PATCH 07/11] perf, tools: Collapse identically named events in  perf stat Jiri Olsa <jolsa@redhat.com> - 2017-01-18 18:00 +0100
      Re: [PATCH 07/11] perf, tools: Collapse identically named events in  perf stat Andi Kleen <ak@linux.intel.com> - 2017-01-18 18:30 +0100

csiph-web