Re: [PATCH v3 2/2] nsfs: Add an ioctl() to return owner UID of a userns

From	"W. Trevor King" <wking@tremily.us>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] nsfs: Add an ioctl() to return owner UID of a userns
Date	2017-01-17 02:30 +0100
Message-ID	<t0qKZ-m4-7@gated-at.bofh.it> (permalink)
References	<t0qrE-f1-9@gated-at.bofh.it> <t0qrE-f1-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jan 17, 2017 at 02:03:29PM +1300, Michael Kerrisk (man-pages) wrote:
> +	case NS_GET_OWNER_UID:
> +		if (ns->ops->type != CLONE_NEWUSER)
> +			return -EINVAL;
> +		user_ns = container_of(ns, struct user_namespace, ns);
> +		argp = (unsigned int __user *) arg;
> +		uid = from_kuid_munged(current_user_ns(), user_ns->owner);
> +		return put_user(uid, argp);
> …
> +/* Get owner UID for a user namespace */
> +#define NS_GET_OWNER_UID	_IO(NSIO, 0x4)

The comment here should probably be:

  Get owner UID (in the current user namespace) for a user namespace

or some such, to convey that current_user_ns is being passed to
from_kuid_munged.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

Thread

[PATCH v3 2/2] nsfs: Add an ioctl() to return owner UID of a userns "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2017-01-17 02:10 +0100
  Re: [PATCH v3 2/2] nsfs: Add an ioctl() to return owner UID of a  userns "W. Trevor King" <wking@tremily.us> - 2017-01-17 02:30 +0100
    Re: [PATCH v3 2/2] nsfs: Add an ioctl() to return owner UID of a userns "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2017-01-19 03:30 +0100
  Re: [PATCH v3 2/2] nsfs: Add an ioctl() to return owner UID of a userns ebiederm@xmission.com (Eric W. Biederman) - 2017-01-24 23:40 +0100

csiph-web