Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1559612
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2] Staging: media: bcm2048: style fix - bare use of unsigned |
| Date | 2017-01-16 11:40 +0100 |
| Message-ID | <t0cRH-7Aa-1@gated-at.bofh.it> (permalink) |
| References | <t09K9-5jY-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jan 16, 2017 at 08:09:51PM +1300, Derek Robson wrote: > Changed macro to not pass signedness and size as seprate fields. > This is to improve code readablity. Not really, it reads just fine as is. In fact, it forces you to think about the signed vs. unsigned of the variable and doesn't let you forget it, which seems to be the intention of the code as-is. So I would recommend just leaving it alone. Remember, checkpatch is a hint, you always have to use your brain when making kernel changes, and always test-build them :) thanks, greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH V2] Staging: media: bcm2048: style fix - bare use of unsigned Derek Robson <robsonde@gmail.com> - 2017-01-16 08:20 +0100 Re: [PATCH V2] Staging: media: bcm2048: style fix - bare use of unsigned Greg KH <gregkh@linuxfoundation.org> - 2017-01-16 11:40 +0100
csiph-web