Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1515375

Re: [PATCH] i2c: make busses/i2c-pxa-pci.c explicitly non-modular

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Oct 31, 2016 at 01:59:47PM -0400, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/i2c/busses/Kconfig:config I2C_PXA_PCI
> drivers/i2c/busses/Kconfig:     def_bool I2C_PXA && X86_32 && PCI && OF
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
> 
> Since module_pci_driver() uses the same init level priority as
> builtin_pci_driver() the init ordering remains unchanged with
> this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: linux-i2c@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Looks OK to me, still I'd like an ack from Sebastian for this patch.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: make busses/i2c-pxa-pci.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-10-31 19:10 +0100
  Re: [PATCH] i2c: make busses/i2c-pxa-pci.c explicitly non-modular Wolfram Sang <wsa@the-dreams.de> - 2016-11-04 20:50 +0100
    Re: [PATCH] i2c: make busses/i2c-pxa-pci.c explicitly non-modular Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-04 21:40 +0100

csiph-web