Re: [PATCH 3/3] ovl: redirect on rename-dir

From	Miklos Szeredi <miklos@szeredi.hu>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ovl: redirect on rename-dir
Date	2016-11-04 14:50 +0100
Message-ID	<szN2x-2k4-5@gated-at.bofh.it> (permalink)
References	<sw4uZ-2vP-5@gated-at.bofh.it> <sw4uZ-2vP-27@gated-at.bofh.it> <sxi2S-2c2-23@gated-at.bofh.it> <szsAO-5Mg-27@gated-at.bofh.it> <szJ8C-8ib-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 4, 2016 at 10:29 AM, Amir Goldstein <amir73il@gmail.com> wrote:

> You did not address my comment about the 'stack' allocation overflow
> in ovl_lookup
> I believe the (possible) overflow is demonstrated by the following debug patch:

Oops, missed that.  Good spotting!

And there's more shit that unionfs-testsuite didn't discover (not even
involving multiple layers):

rm -rf /lower /upper /work
mkdir -p /lower/a/b/c /upper /work
mount -t overlay overlay -oupperdir=/upper,lowerdir=/lower,workdir=/work /mnt
mv /mnt/a /mnt/z
mv /mnt/z/b /mnt/q
ls /mnt/q
umount /mnt
mount -t overlay overlay -oupperdir=/upper,lowerdir=/lower,workdir=/work /mnt
ls /mnt/q
umount /mnt

Next update coming up...

Thanks,
Miklos

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] ovl: redirect on rename-dir Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-28 18:20 +0200
  Re: [PATCH 3/3] ovl: redirect on rename-dir Miklos Szeredi <miklos@szeredi.hu> - 2016-11-03 17:00 +0100
    Re: [PATCH 3/3] ovl: redirect on rename-dir Amir Goldstein <amir73il@gmail.com> - 2016-11-04 10:40 +0100
      Re: [PATCH 3/3] ovl: redirect on rename-dir Miklos Szeredi <miklos@szeredi.hu> - 2016-11-04 14:50 +0100

csiph-web