[PATCH 6/6] g_NCR5380: Fix release region in error handling

From	Ondrej Zary <linux@rainbow-software.org>
Newsgroups	linux.kernel
Subject	[PATCH 6/6] g_NCR5380: Fix release region in error handling
Date	2016-10-31 21:30 +0100
Message-ID	<syrns-7fi-9@gated-at.bofh.it> (permalink)
References	<syrns-7fi-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

When a SW-configurable card is specified but not found, the driver
releases wrong region, causing the following message in kernel log:
Trying to free nonexistent resource <0000000000000000-000000000000000f>

Fix it by assigning base earlier.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
 drivers/scsi/g_NCR5380.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
index 6a08d3e..d33e71f 100644
--- a/drivers/scsi/g_NCR5380.c
+++ b/drivers/scsi/g_NCR5380.c
@@ -258,12 +258,12 @@ static int generic_NCR5380_init_one(struct scsi_host_template *tpnt,
 		if (ports[i]) {
 			/* At this point we have our region reserved */
 			magic_configure(i, 0, magic); /* no IRQ yet */
-			outb(0xc0, ports[i] + 9);
-			if (inb(ports[i] + 9) != 0x80) {
+			base = ports[i];
+			outb(0xc0, base + 9);
+			if (inb(base + 9) != 0x80) {
 				ret = -ENODEV;
 				goto out_release;
 			}
-			base = ports[i];
 			port_idx = i;
 		} else
 			return -EINVAL;
-- 
Ondrej Zary

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] g_NCR5380: Fix release region in error handling Ondrej Zary <linux@rainbow-software.org> - 2016-10-31 21:30 +0100
  Re: [PATCH 6/6] g_NCR5380: Fix release region in error handling Finn Thain <fthain@telegraphics.com.au> - 2016-11-02 08:50 +0100

csiph-web