Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1512634

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments
Date 2016-10-31 16:40 +0100
Message-ID <symQO-4eD-31@gated-at.bofh.it> (permalink)
References <sxx1U-3GR-3@gated-at.bofh.it> <sxxlf-3Nw-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote:
> Avoid to access .bi_vcnt directly, because it may be not what
> the driver expected any more after supporting multipage bvec.
> 
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>

It would be really nice to have a comment in the code why it's
even checking for multiple segments.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments Ming Lei <tom.leiming@gmail.com> - 2016-10-29 10:40 +0200
  Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with  !bio_multiple_segments Christoph Hellwig <hch@infradead.org> - 2016-10-31 16:40 +0100
    Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments Ming Lei <tom.leiming@gmail.com> - 2016-11-01 00:10 +0100
    Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with  !bio_multiple_segments Kent Overstreet <kent.overstreet@gmail.com> - 2016-11-02 04:10 +0100
      Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments Ming Lei <tom.leiming@gmail.com> - 2016-11-02 09:00 +0100
        Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with  !bio_multiple_segments Mike Snitzer <snitzer@redhat.com> - 2016-11-02 15:30 +0100
          Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments Ming Lei <tom.leiming@gmail.com> - 2016-11-03 00:50 +0100

csiph-web