Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512193

[PATCH 6/9] s390: hotplug: make pci_hpc explicitly non-modular

Show all headers | View raw

The Kconfig currently controlling compilation of this code is:

drivers/pci/hotplug/Kconfig:config HOTPLUG_PCI_S390
drivers/pci/hotplug/Kconfig:    bool "System z PCI Hotplug Support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

We don't exchange module.h for init.h or export.h since the file
does not contain any initcalls or EXPORT of symbols.

Cc: Sebastian Ott <sebott@linux.vnet.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/pci/hotplug/s390_pci_hpc.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/hotplug/s390_pci_hpc.c b/drivers/pci/hotplug/s390_pci_hpc.c
index 50b8b7d54416..530d0e49f2ed 100644
--- a/drivers/pci/hotplug/s390_pci_hpc.c
+++ b/drivers/pci/hotplug/s390_pci_hpc.c
@@ -5,12 +5,13 @@
  *
  * Author(s):
  *   Jan Glauber <jang@linux.vnet.ibm.com>
+ *
+ * License: GPL
  */
 
 #define KMSG_COMPONENT "zpci"
 #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
 
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/pci.h>
@@ -21,10 +22,6 @@
 #define SLOT_NAME_SIZE	10
 static LIST_HEAD(s390_hotplug_slot_list);
 
-MODULE_AUTHOR("Jan Glauber <jang@linux.vnet.ibm.com");
-MODULE_DESCRIPTION("Hot Plug PCI Controller for System z");
-MODULE_LICENSE("GPL");
-
 static int zpci_fn_configured(enum zpci_state state)
 {
 	return state == ZPCI_FN_STATE_CONFIGURED ||
-- 
2.10.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] s390: remove modular usage from non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-10-30 21:40 +0100
  [PATCH 7/9] s390: hypfs: make inode explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-10-30 21:50 +0100
  [PATCH 6/9] s390: hotplug: make pci_hpc explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-10-30 21:50 +0100
  [PATCH 3/9] s390: char: make con3215 explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-10-30 21:50 +0100
  [PATCH 5/9] s390: char: make slcp_quiesce explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-10-30 21:50 +0100
  [PATCH 2/9] s390: char: make zcore explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-10-30 21:50 +0100
  Re: [PATCH 0/9] s390: remove modular usage from non-modular code Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-10-31 10:30 +0100

csiph-web