Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

From	Jacob Pan <jacob.jun.pan@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state
Date	2016-10-27 22:30 +0200
Message-ID	<swZtf-6Gr-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <suOsh-26F-1@gated-at.bofh.it> <svPFD-17R-5@gated-at.bofh.it> <svQLo-1O1-31@gated-at.bofh.it> <swUjV-3ga-53@gated-at.bofh.it> <swUDg-3BS-11@gated-at.bofh.it>
Organization	OTC

Show all headers | View raw

On Thu, 27 Oct 2016 17:17:26 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> On 2016-10-27 16:53:48 [+0200], Petr Mladek wrote:
> > 
> > In each case, I wonder if the problem is caused by the conversion
> > to the kthread worker or by the CPU hotplug state conversion.  
> 
> drop the hotplug patch and you will see.
> 
Petr,

I dropped hp patch no long see the hang during suspend to s3. However,
the problem seems to be this line,

diff --git a/drivers/thermal/intel_powerclamp.c
b/drivers/thermal/intel_powerclamp.c index 390e50b..b61da57 100644
--- a/drivers/thermal/intel_powerclamp.c
+++ b/drivers/thermal/intel_powerclamp.c
@@ -574,7 +574,7 @@ static void stop_power_clamp_worker(unsigned long
cpu) */
        del_timer_sync(&w_data->wakeup_timer);
        clear_bit(w_data->cpu, cpu_clamping_mask);
-       kthread_destroy_worker(w_data->worker);
+//     kthread_destroy_worker(w_data->worker);
 
        w_data->worker = NULL;
 }

If I do the above, everything works with S3 and CPU HP patch.

Inside kthread_destroy_worker()
	kthread_flush_worker(worker);
never completes then blocks s3 entry!

I will be at LPC next week also, we can chat about that.


Thanks,

Jacob


> > Best Regards,
> > Petr  
> 
> Sebastian

[Jacob Pan]

Thread

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug  state Petr Mladek <pmladek@suse.com> - 2016-10-27 17:00 +0200
  Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug  state Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-10-27 17:20 +0200
    Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug  state Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-10-27 22:30 +0200
      Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug  state Petr Mladek <pmladek@suse.com> - 2016-11-11 10:40 +0100
        Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug  state Petr Mladek <pmladek@suse.com> - 2016-11-11 11:10 +0100
          Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug  state Petr Mladek <pmladek@suse.com> - 2016-11-11 18:40 +0100

csiph-web