Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4

From	Rayagond Kokatanur <rayagond@vayavyalabs.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4
Date	2016-10-27 16:10 +0200
Message-ID	<swTxw-2VB-35@gated-at.bofh.it> (permalink)
References	<swqvv-i6-3@gated-at.bofh.it> <swqvv-i6-13@gated-at.bofh.it> <swTxw-2VB-37@gated-at.bofh.it> <swTxw-2VB-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Oct 27, 2016 at 4:02 PM, Giuseppe CAVALLARO
<peppe.cavallaro@st.com> wrote:
> Hello Rayagond !
>
> On 10/27/2016 12:25 PM, Rayagond Kokatanur wrote:
>>>
>>> +static int dwmac4_wrback_get_rx_timestamp_status(void *desc, u32 ats)
>>> >  {
>>> >         struct dma_desc *p = (struct dma_desc *)desc;
>>> > +       int ret = -EINVAL;
>>> > +
>>> > +       /* Get the status from normal w/b descriptor */
>>> > +       if (likely(p->des3 & TDES3_RS1V)) {
>>> > +               if (likely(p->des1 & RDES1_TIMESTAMP_AVAILABLE)) {
>>> > +                       int i = 0;
>>> > +
>>> > +                       /* Check if timestamp is OK from context
>>> > descriptor */
>>> > +                       do {
>>> > +                               ret = dwmac4_rx_check_timestamp(desc);
>>
>> Here, "desc" is not pointing to next descriptor (ie context
>> descriptor). Driver should check the context descriptor.
>
>
> you are right and this is done by the caller:  stmmac_get_rx_hwtstamp

Yes.

>
> Cheers
> peppe
>



-- 
wwr
Rayagond

Thread

[PATCH (net.git) 0/3] stmmac: fix PTP support Giuseppe Cavallaro <peppe.cavallaro@st.com> - 2016-10-26 09:10 +0200
  [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4 Giuseppe Cavallaro <peppe.cavallaro@st.com> - 2016-10-26 09:10 +0200
    Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4 Rayagond Kokatanur <rayagond@vayavyalabs.com> - 2016-10-27 16:10 +0200
      Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4 Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2016-11-02 07:40 +0100
        Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4 Rayagond Kokatanur <rayagond@vayavyalabs.com> - 2016-11-02 08:10 +0100
    Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4 Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2016-10-27 16:50 +0200
    Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4 Rayagond Kokatanur <rayagond@vayavyalabs.com> - 2016-10-27 17:00 +0200
  [PATCH (net.git) 1/3] stmmac: update the PTP header file Giuseppe Cavallaro <peppe.cavallaro@st.com> - 2016-10-26 09:10 +0200
  Re: [PATCH (net.git) 0/3] stmmac: fix PTP support Alexandre Torgue <alexandre.torgue@st.com> - 2016-10-26 09:40 +0200
  Re: [PATCH (net.git) 0/3] stmmac: fix PTP support Richard Cochran <richardcochran@gmail.com> - 2016-10-26 11:10 +0200
    Re: [PATCH (net.git) 0/3] stmmac: fix PTP support Rayagond Kokatanur <rayagond@vayavyalabs.com> - 2016-11-02 08:10 +0100
  Re: [PATCH (net.git) 0/3] stmmac: fix PTP support Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2016-11-04 15:00 +0100
    Re: [PATCH (net.git) 0/3] stmmac: fix PTP support David Miller <davem@davemloft.net> - 2016-11-04 16:40 +0100

csiph-web