Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks
Date	2016-10-26 23:50 +0200
Message-ID	<swEf8-11E-17@gated-at.bofh.it> (permalink)
References	<stmy5-8ps-15@gated-at.bofh.it> <sutxv-4IC-15@gated-at.bofh.it> <suA5X-N7-5@gated-at.bofh.it> <svNDP-8aC-1@gated-at.bofh.it> <swE5s-Ye-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 26 Oct 2016, Darren Hart wrote:
> On Mon, Oct 24, 2016 at 01:38:54PM +0000, Tirdea, Irina wrote:
> > intel_pmc_* drivers or is it enough to move it as a standalone driver for now?
> 
> If the functionality is substantially different, then I don't see a
> compelling, and certainly not an immediate, need to merge them. Assume
> for now they are to remain as separate drivers. I suggest keeping the
> existing name for now as well. Let's just complete the move with as
> little user-visible changes as possible.
> 
> The placement of the header file is a bit tricky as it is being used in
> drivers/clk/x86 in addition to the pmc_atom driver in
> drivers/platform/x86.
> 
> The best existing location would appear to be include/platform_data/
> 
> Thomas, is that acceptable to you?

Yes

> arch/x86/platform/atom/pmc_atom.c -> drivers/platform/x86
> arch/x86/include/asm/pmc_atom.h -> include/platform_data/
> 
> If there are enough of these, it might make sense to create:
> 
> include/platform/x86/
> 
> but I suggest we start with minimal change.

No. Make that x86 directory right away. include/platform_data is already a
maze of 224 files. Start structuring it now.

Thanks,

	tglx

Thread

[RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Irina Tirdea <irina.tirdea@intel.com> - 2016-10-17 22:20 +0200
  Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Thomas Gleixner <tglx@linutronix.de> - 2016-10-21 00:00 +0200
    Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Darren Hart <dvhart@infradead.org> - 2016-10-21 07:00 +0200
      RE: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-10-24 15:40 +0200
        Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Darren Hart <dvhart@infradead.org> - 2016-10-26 23:40 +0200
          Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 23:50 +0200
            Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Darren Hart <dvhart@infradead.org> - 2016-10-27 00:10 +0200
              RE: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-10-27 16:50 +0200

csiph-web