Re: [PATCH] gpio: mpc8xxx: Correct irq handler function

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: mpc8xxx: Correct irq handler function
Date	2016-10-25 11:20 +0200
Message-ID	<sw63M-3ER-29@gated-at.bofh.it> (permalink)
References	<svBjk-8w3-9@gated-at.bofh.it> <svBjk-8w3-7@gated-at.bofh.it> <svEKe-2pP-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 24, 2016 at 5:46 AM, Gang Liu <gang.liu@nxp.com> wrote:
>> On Fri, Oct 21, 2016 at 9:31 AM, Liu Gang <Gang.Liu@nxp.com> wrote:
>>
>> > From the beginning of the gpio-mpc8xxx.c, the "handle_level_irq"
>> > has being used to handle GPIO interrupts in the PowerPC/Layerscape
>> > platforms. But actually, almost all PowerPC/Layerscape platforms
>> > assert an interrupt request upon either a high-to-low change or any
>> > change on the state of the signal.
>> >
>> > So the "handle_level_irq" is not reasonable for PowerPC/Layerscape
>> > GPIO interrupt, it should be "handle_edge_irq". Otherwise the system
>> > may lost some interrupts from the PIN's state changes.
>> >
>> > Signed-off-by: Liu Gang <Gang.Liu@nxp.com>
>>
>> Yes and especially so since this irqchip implements .irq_ack() and unless you
>> use the edge handler it will never be called.
>>
>> Patch applied for fixes, tell me if it also needs to go into stable.
>>
> [Liu Gang] yes, please also put it into stable. Thanks!

Ooops too late. Will tell Greg to pick this separately.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: mpc8xxx: Correct irq handler function Linus Walleij <linus.walleij@linaro.org> - 2016-10-24 02:30 +0200
  RE: [PATCH] gpio: mpc8xxx: Correct irq handler function Gang Liu <gang.liu@nxp.com> - 2016-10-24 06:10 +0200
    Re: [PATCH] gpio: mpc8xxx: Correct irq handler function Linus Walleij <linus.walleij@linaro.org> - 2016-10-25 11:20 +0200

csiph-web