Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1507453

Re: net/can: warning in bcm_connect/proc_register

From Cong Wang <xiyou.wangcong@gmail.com>
Newsgroups linux.kernel
Subject Re: net/can: warning in bcm_connect/proc_register
Date 2016-10-24 19:00 +0200
Message-ID <svQLo-1O1-35@gated-at.bofh.it> (permalink)
References <svQin-1Di-65@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Oct 24, 2016 at 9:21 AM, Andrey Konovalov <andreyknvl@google.com> wrote:
> Hi,
>
> I've got the following error report while running the syzkaller fuzzer:
>
> WARNING: CPU: 0 PID: 32451 at fs/proc/generic.c:345 proc_register+0x25e/0x300
> proc_dir_entry 'can-bcm/249757' already registered
> Kernel panic - not syncing: panic_on_warn set ...

Looks like we have two problems here:

1) A check for bo->bcm_proc_read != NULL seems missing
2) We need to lock the sock in bcm_connect().

I will work on a patch. Meanwhile, it would help a lot if you could provide
a reproducer.

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

net/can: warning in bcm_connect/proc_register Andrey Konovalov <andreyknvl@google.com> - 2016-10-24 18:30 +0200
  Re: net/can: warning in bcm_connect/proc_register Cong Wang <xiyou.wangcong@gmail.com> - 2016-10-24 19:00 +0200
    Re: net/can: warning in bcm_connect/proc_register Andrey Konovalov <andreyknvl@google.com> - 2016-10-24 19:40 +0200
      Re: net/can: warning in bcm_connect/proc_register Oliver Hartkopp <socketcan@hartkopp.net> - 2016-10-24 20:30 +0200

csiph-web