Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1505270

Re: [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages

Show all headers | View raw

On Thu, Oct 20, 2016 at 12:21 AM, Sinan Kaya <okaya@codeaurora.org> wrote:
> The penalty determination of ISA IRQ goes through 4 paths.
> 1. assign PCI_USING during power up via acpi_irq_penalty_init.
> 2. update the penalty with acpi_penalize_isa_irq function based on the
> active parameter.
> 3. kernel command line penalty update via acpi_irq_penalty_update function.
> 4. increment the penalty as USING right after the IRQ is assign to PCI.
>
> acpi_penalize_isa_irq and acpi_irq_penalty_update functions get called
> before the ACPI subsystem is started.
>
> These API need to bypass the acpi_irq_get_penalty function.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> ---
>  drivers/acpi/pci_link.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index c983bf7..4f37938 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -849,7 +849,7 @@ static int __init acpi_irq_penalty_update(char *str, int used)
>                         continue;
>
>                 if (used)
> -                       new_penalty = acpi_irq_get_penalty(irq) +
> +                       new_penalty = acpi_isa_irq_penalty[irq] +
>                                         PIRQ_PENALTY_ISA_USED;
>                 else
>                         new_penalty = 0;
> @@ -871,7 +871,7 @@ static int __init acpi_irq_penalty_update(char *str, int used)
>  void acpi_penalize_isa_irq(int irq, int active)
>  {
>         if ((irq >= 0) && (irq < ARRAY_SIZE(acpi_isa_irq_penalty)))
> -               acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) +
> +               acpi_isa_irq_penalty[irq] = acpi_isa_irq_penalty[irq] +

This looks slightly odd.  What about

+               acpi_isa_irq_penalty[irq] +=

>                   (active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING);
>  }
>

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages Sinan Kaya <okaya@codeaurora.org> - 2016-10-20 00:30 +0200
  Re: [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during  early boot stages "Rafael J. Wysocki" <rafael@kernel.org> - 2016-10-20 23:40 +0200
    Re: [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during  early boot stages Sinan Kaya <okaya@codeaurora.org> - 2016-10-24 05:50 +0200
  Re: [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during  early boot stages Bjorn Helgaas <helgaas@kernel.org> - 2016-10-21 03:40 +0200
    Re: [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during  early boot stages Bjorn Helgaas <helgaas@kernel.org> - 2016-10-21 16:10 +0200
    Re: [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during  early boot stages Sinan Kaya <okaya@codeaurora.org> - 2016-10-24 05:30 +0200
  Re: [V4, 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early  boot stages Jonathan Liu <net147@gmail.com> - 2016-10-23 05:50 +0200
    Re: [V4, 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early  boot stages Sinan Kaya <okaya@codeaurora.org> - 2016-10-24 06:20 +0200
      Re: [V4, 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early  boot stages Jonathan Liu <net147@gmail.com> - 2016-10-24 06:30 +0200

csiph-web